Make event dispatch synchronous #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change event dispatch process from calling event handlers in an async (setTimeout) fashion to sync calls. This fixes potential race conditions when a specific order of event processing is expected (e.g. showing and hiding loading progress spinner).
|
This needs to have proper error handling (at least by ignoring or simply logging errors). Also we might want to support both sync and async |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change event dispatch process from calling event handlers in an async (setTimeout) fashion to sync calls. This fixes potential race conditions when a specific order of event processing is expected (e.g. showing and hiding loading progress spinner).
Why I see this as a meaningful change? The decision to process any event in async fashion shuold be done by the event subscriber, not the event dispatcher / manager. Or potentially the triggering component might want to send event asynchronously... again, that decision should not be made by the dispatcher / manager.